Address npm dependency issues found in master branch [Opened by bitHound]

reactioncommerce / reaction-cli

A command line tool for working with Reaction Commerce.

33 stars 20 forks source link

Address npm dependency issues found in master branch [Opened by bitHound] #45

Closed aaronjudd closed 6 years ago

aaronjudd commented 7 years ago

bitHound discovered:

1 package with at least one security vulnerability.
1 unused package.

For details go to bitHound.

aaronjudd commented 6 years ago

This is a critical impact issue and needs an update. Can you please update the status?

jshimko commented 6 years ago

I have to replace all usage of shelljs with native Node libs. The issue is only with the exec method in shelljs, but we're going to see the error whether we're using that method or not. So that leaves us with no other option but to replace the entire lib. That's absolutely the plan, but it's probably going to be at least a half day of work once I get to it (which was planned for this week).

aaronjudd commented 6 years ago

Status of replacing shelljs?

jshimko commented 6 years ago

This was a bit of a project, but it has finally been completed and released in v0.22.1. And shelljs has been entirely removed.

https://github.com/reactioncommerce/reaction-cli/compare/d2ff805...06f7a7c