reactioncommerce / reaction-cli

A command line tool for working with Reaction Commerce.
33 stars 20 forks source link

--inspect-brk argument triggers crash on startup #78

Closed loan-laux closed 5 years ago

loan-laux commented 5 years ago

Using --inspect-brk=0.0.0.0 to make the Node debugger listen to all IPs instead of the default 127.0.0.1 triggers a crash on startup.

This happens because, in the meteor command generated by reaction-cli, a space is used instead of an = between --inspect-brk and the IP that was passed to the argument. Node/Meteor expects an =, and throws a syntax error.

The solution would be to process --inspect-brk separately from the rest of the arguments, and to use an = instead of a space when necessary.

loan-laux commented 5 years ago

Closing as the PR was merged.