search

reactioncommerce / reaction-component-library

Example Storefront Component Library: A set of React components for the Example Storefront
Apache License 2.0
96 stars 57 forks source link

TextInput: Icon size issue in text input component on docs. #162

Closed mikemurray closed 6 years ago

mikemurray commented 6 years ago

Type: major

Describe the bug

The icon in text input grows as you shrink the viewport

To Reproduce

  1. Go to https://stoic-hodgkin-c0179e.netlify.com/#!/TextInput
  2. Scroll down to the bottom with the text input with the x button
  3. Resize your window smaller
  4. Witness the enlargement of the icon

Expected behavior

Icons should obey size constraints.

Screenshots

textinput_ _reaction_design_system

Desktop (please complete the following information):

spencern commented 6 years ago

I've seen this as well.

aldeed commented 6 years ago

I spent a lot of time getting the right combination of styles for the icon to resize properly with the field and the base font size, so when we fix this, we'll have to make sure we don't break those things. We should come up with a list of manual tests to do (or automatic visual regression if possible)

rc-publisher commented 6 years ago

:tada: This issue has been resolved in version 0.14.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: