search

reactioncommerce / reaction-eslint-config

Reaction Eslint Configuration
MIT License
5 stars 6 forks source link

feat: make all rules errors instead of warnings #17

Closed kieckhafer closed 5 years ago

kieckhafer commented 5 years ago

Resolves #5 Resolves #7 Resolves #12 Resolves #13

We have cleaned up our codebase enough where all rules are either clean, or are overridden with a warn instead of a error locally inside of package.json. Changing all rules to error will guarantee no new eslint issues are introduced in the future.

kieckhafer commented 5 years ago

@aldeed added the node plugin, and updated all the dependencies. https://github.com/reactioncommerce/reaction/pull/5308 has been merged into reaction to override existing issues as warn, so this is good to be merged if it looks OK.

kieckhafer commented 5 years ago

@zenweasel @rosshadden @aldeed don't need all three of you to approve, just whomever gets to it first, but since you all had input just wanted to tag you all.

Once merged, I'll make the release 2.0 from it, then create a PR in Reaction to update to 2.0. The PR that provided warn overrides in Reaction has already been merged, so this should have no effect for our existing rules, I'll probably have to add a warn override for some of the new eslint-plugin-node rules for now, but will do that in the update branch in reaction.

rc-publisher commented 5 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: