search

reactioncommerce / reaction-eslint-config

Reaction Eslint Configuration
MIT License
5 stars 6 forks source link

Add `id-length` exception for `_` #2

Closed pmn4 closed 6 years ago

pmn4 commented 6 years ago

Commonly used in import _ from "lodash";

This is a personal preference, but I also like to use _ to indicate that a method variable is required, but not used (it's more of a Ruby convention, but I like it)

for reference: https://eslint.org/docs/rules/id-length#exceptions

brent-hoover commented 6 years ago

This is also a convention in Python and Erlang and I think a growing consensus in JS

brent-hoover commented 6 years ago

For an official ruling from the judges I would request @aldeed's opinion

aldeed commented 6 years ago

I'm ok with this. We do use the _ placeholder in some places that are complaining about this, in addition to lodash

spencern commented 6 years ago

I'm okay with this as well. 👍