refactor: commonjs require understands json files

reactioncommerce / reaction-eslint-config

Reaction Eslint Configuration

MIT License

5 stars 6 forks source link

refactor: commonjs require understands json files #6

Closed focusaurus closed 5 years ago

focusaurus commented 5 years ago

Sticking an index.json file in the package root directory is sufficient for node to find and parse the JSON. The require() function understands both js and json files directly.

aldeed commented 5 years ago

Cool! I'll merge this, which will trigger NPM publish. If we then update one of the projects to use the new version and it still picks up the proper config, we're good. If not, we can revert this.

aldeed commented 5 years ago

Actually the only commit uses refactor:, so that might not trigger a publish.

focusaurus commented 5 years ago

Yeah I also added [skip release] to reduce noise. Next time we make an actual change, we'll see for certain whether this works but I'm confident it's correct.

rc-publisher commented 5 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: