search

reactioncommerce / reaction-feature-requests

Reaction Feature Requests
13 stars 1 forks source link

Allow for a way to install APM code w/o modifying core #123

Open brent-hoover opened 4 years ago

brent-hoover commented 4 years ago

Most commercial organizations want to use New Relic and/or Sentry or similar tools to track performance and errors. Unfortunately most of these require that you import the code at or near the top of the stack so all code gets loaded afterwards. RC should provide some sort of optional bootstrap point where these can be added without having to modify any of the core file.

This could be as simple as just using a conditional import to a file if it exists or similar

griggheo commented 4 years ago

As a coincidence, I just encountered this situation earlier today when trying to instrument our node apps with Honeycomb.

On Tue, Nov 19, 2019 at 7:59 PM Brent Hoover notifications@github.com wrote:

Most commercial organizations want to use New Relic and/or Sentry or similar tools to track performance and errors. Unfortunately most of these require that you import the code at or near the top of the stack so all code gets loaded afterwards. RC should provide some sort of optional bootstrap point where these can be added without having to modify any of the core file.

This could be as simple as just using a conditional import to a file if it exists or similar

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/reactioncommerce/reaction-feature-requests/issues/123?email_source=notifications&email_token=AABO2V73J52BYRWYPET7RIDQUSYZ5A5CNFSM4JPM5Q4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2RQQ2A, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABO2V7YQT4BBXSNVEJBVPDQUSYZ5ANCNFSM4JPM5Q4A .

focusaurus commented 4 years ago

There are some long term intentions (nothing more at the moment) to make reaction a library, which as an additional effect would facilitate instrumentation and customization for APM and other customizations.

On Tue, Nov 19, 2019, 9:02 PM Grig Gheorghiu notifications@github.com wrote:

As a coincidence, I just encountered this situation earlier today when trying to instrument our node apps with Honeycomb.

On Tue, Nov 19, 2019 at 7:59 PM Brent Hoover notifications@github.com wrote:

Most commercial organizations want to use New Relic and/or Sentry or similar tools to track performance and errors. Unfortunately most of these require that you import the code at or near the top of the stack so all code gets loaded afterwards. RC should provide some sort of optional bootstrap point where these can be added without having to modify any of the core file.

This could be as simple as just using a conditional import to a file if it exists or similar

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/reactioncommerce/reaction-feature-requests/issues/123?email_source=notifications&email_token=AABO2V73J52BYRWYPET7RIDQUSYZ5A5CNFSM4JPM5Q4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2RQQ2A , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABO2V7YQT4BBXSNVEJBVPDQUSYZ5ANCNFSM4JPM5Q4A

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/reactioncommerce/reaction-feature-requests/issues/123?email_source=notifications&email_token=AADVYSI6HGOUJCIDBIOCMKTQUSZGNA5CNFSM4JPM5Q4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQUCQY#issuecomment-555827523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADVYSJBCTHAPQCMAYIIJ73QUSZGNANCNFSM4JPM5Q4A .