reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.35k stars 2.17k forks source link

AvaTax TaxCodes and UI Certification #1793

Closed aaronjudd closed 7 years ago

aaronjudd commented 7 years ago

Additional UI and functionality is needed to have our AvaTax module be "certified".

Some are additional settings, and will need UI in the dashboard settings.

Implementation requirements are here: http://developer.avalara.com/avatax/testing-your-integration/

Integration checklist for Functional Review http://developer.avalara.com/avatax/certification/

Use Case for handling Exemptions http://developer.avalara.com/avatax/handling-tax-exempt-customers/

Using the RESTv2 API, there are two http headers we need to pass:

Swagger (AvaTax API reference) https://rest.avatax.com/swagger/ui/index.html

These endpoints can be used to retrieve TaxCodes,etc. TaxCodes will need to be stored on product, see #1699 Line Item calculation is required (should already be wired this way).

Testing can be validated here: http://developer.avalara.com/avatax/self-test/

Future - Developer Blog post on Landed Cost using RESTv2 API http://developer.avalara.com/blog/2016/10/13/landedcost-with-rest-v2/

aaronjudd commented 7 years ago

Example certification settings: screenshot_2_6_17__5_00_pm

brent-hoover commented 7 years ago

For us the Tax codes for Shipping/Handling should probably go in the Avalara tax settings panel

brent-hoover commented 7 years ago

Some Todo items here:

brent-hoover commented 7 years ago

Current audit self-test results

developer___integration_self-test

brent-hoover commented 7 years ago

We had the compliance audit today and here were the issues that came up:

Compliance Issues

  1. Biggest Issue Breaking out quantities into individual items is going to cause some issues with Avalara's limits on order sizes. #2102
  2. We need to warn but not stop customers from proceeding with an order if the address fails complete address validation. (do we need to record the fact that it didn't validate?) #2104
  3. The Order ID displayed in the admin panel and the Order ID being transmitted to Avalara is not the same so it's hard to cross-reference the two. #2103
  4. "Customer Usage Type" doesn't allow you to set a custom value. #2101

Not blockers for compliance but things on the horizon:

  1. Location code for Retail locations (Evereve?)
  2. "Tax Included" for VAT retailers
brent-hoover commented 7 years ago

Ok, so the "biggest issue" wasn't the biggest issue, address validation is. But once #2104 is completed we should be good to go. Moving out to 1.2

brent-hoover commented 7 years ago

We are certified. Closing