search

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.34k stars 2.17k forks source link

Development version of React in production #2629

Closed callmephilip closed 6 years ago

callmephilip commented 7 years ago

I am checking https://hello.reactioncommerce.com/ with React Developer Tools and it says that the site is using development version of React. Does this deployment do it intentionally or is this a bug?

aaronjudd commented 7 years ago

This should have been resolved with the release of Meteor 1.5.1 https://blog.meteor.com/announcing-meteor-1-5-1-b65ecddf955b

we're using https://github.com/abernix/standard-minifier-js 2.1.0 instead of https://github.com/meteor/meteor/tree/devel/packages/standard-minifier-js 2.1.1

The abernix package apparently hasn't yet been updated since the release of 2.1.1.

brent-hoover commented 6 years ago

I still see this issue on https://swag.getreaction.io using RC 1.5.11. Checking a couple of the sites on the community showcase they appear to also using the development version of React.

brent-hoover commented 6 years ago

Since this affects sites in production I am tempted to bump this bug up to critical. Any input @aaronjudd?

brent-hoover commented 6 years ago

Spoke to @aaronjudd this morning and we agreed that this needs to be bumped up to critical and we need to resolve it now.

jshimko commented 6 years ago

Switched back to standard-minifier-js and that fixed it. Just did a Docker build of master with standard-minifier-js added and the abernix fork removed and it is now properly compiling React.

brent-hoover commented 6 years ago

Now the mystery is, why did we switch in the first place and is it safe to switch back? 🤔

brent-hoover commented 6 years ago

Closed via #3363