Closed cindyfirestone closed 6 years ago
same here
@spencern
https://github.com/reactioncommerce/reaction/blame/master/client/modules/core/main.js#L327
What are your thoughts on updating hasShopSwitcherAccess
to only show the switcher if you are the overall Marketplace admin (Primary shop admin) instead of a user with dashboard access to any shop?
Something like this:
hasShopSwitcherAccess() {
return hasAdminAccess(getPrimaryShopId());
},
hasShopSwitcherAccess()
is not used anywhere in the app, it's declared here and that's it.
@kieckhafer we may need to show this shopSwitcher if you have admin access on more than one shop. E.g. writing Reaction wrapper around Roles.getGroupsForUsers("admin") returns > 1 shopId.
Additionally, once we remove this, it becomes super important to verify that a user always has their activeShop set to the shop they have admin access for on login, and that it's unset on logout (in case of public computer, multi-user computer, etc)
Merged in #3375
Expected behavior
As a store operator with a shop on a marketplace, when I log into my shop it should land me on the shop associated with the account I logged in with.
Actual behavior
When I login, it lands me on the main marketplace, and I need to go into the dropdown in the upper left hand corner and select my shop.
Steps to reproduce the behavior