search

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.34k stars 2.17k forks source link

Convert Search Modal to React #3424

Closed brent-hoover closed 6 years ago

brent-hoover commented 6 years ago

This consumer-facing component is still in Blaze.

Part of #3203

spencern commented 6 years ago

@rymorgan do we have designs for contextual search?

kieckhafer commented 6 years ago

Designs for Account search: http://zpl.io/a3qJqA2

brent-hoover commented 6 years ago

Is this Account search? I think this ticket is meant to deal with the main consumer-facing search. I think there is a separate ticket already for account search.

kieckhafer commented 6 years ago

@zenweasel Yes, it's for accounts, but moving accounts out of this modal, so it kind of makes sense to be here too. Part of converting this to React is removing taco-table from the modal, which is part of the account search.

Looks like #3119 and #2903 are related for accounts search.

mikemurray commented 6 years ago

Added PR https://github.com/reactioncommerce/reaction/pull/3801 as a blocker. While there are many ways to remove the need to use Blaze to inject the search modal into the dom tree, we should consider using React 16 portals to do that job.