Various translations not showing up and not falling back throughout order fulfilment

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.

https://mailchimp.com/developer/open-commerce/

GNU General Public License v3.0

12.34k stars 2.17k forks source link

Closed kieckhafer closed 6 years ago

kieckhafer commented 6 years ago

Translations should be available, or fallbacks should be available, throughout the app

There are various locations where translations are not loading, and fallbacks are not either.

Node: 9.5.0
NPM: 5.6.0
Meteor Node: 8.9.3
Meteor NPM: 5.5.1
Reaction CLI: 0.27.0
Reaction: 1.8.0
Reaction branch: release-1.8.0
Docker: 18.01.0-ce

QA by @kieckhafer + @cassytaylor

prinzdezibel commented 6 years ago

prinzdezibel commented 6 years ago

@spencern Hi Spencer, is there a reason you put that back to "in progress" ? From my side this can be reviewed.

spencern commented 6 years ago

not on purpose, I think it did that automatically when I connected it to an issue. Has this been merged already?

spencern commented 6 years ago

@prinzdezibel is this finished? I see it was mentioned in #3724 but was not closed by that issue at the time.

prinzdezibel commented 6 years ago

@spencern Yes, it was merged in. Going to close this issue.