search

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.34k stars 2.17k forks source link

Translation missing on email connection failed message #3697

Closed sophiehe closed 6 years ago

sophiehe commented 6 years ago

Expected behavior

Buttons should display translation, eg. 'Save' and 'Cancel.'

Actual behavior

image

Steps to reproduce the behavior

  1. Click on Email.
  2. Click on 'Mail Provider' settings icon.
  3. Enter incorrect credentials into 'Edit Settings' fields.
  4. Click 'Save.'

Versions

Node: 6.5.0 NPM: 3.10.3 Meteor Node: 8.9.3 Meteor NPM: 5.5.1 Reaction CLI: 0.19.0 Reaction: 1.8.0 Reaction branch: release-1.8.0

prinzdezibel commented 6 years ago

This is most probably a duplicate of: https://github.com/reactioncommerce/reaction/issues/3694

brent-hoover commented 6 years ago

I defer to however @spencern wants to handle it but I prefer keeping these in separate tickets and disagree they are "duplicates" since they talk about different parts of the app.

prinzdezibel commented 6 years ago

Agree to keep them in separate tickets. I just mentioned it because it can possibly save some time if one would check that first.

spencern commented 6 years ago

@prinzdezibel Is this still an issue?

brent-hoover commented 6 years ago

I just confirmed that this is no longer happening. Closing