search

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.34k stars 2.17k forks source link

Cannot create password when invited to create account #3805

Closed spencern closed 6 years ago

spencern commented 6 years ago

Summary When being invited to create an account as a shop manager or a merchant shop owner, the password overlay spinner is never turned off. image

It appears that the lifecycle method componentWillReceiveProps is never fired for this password overlay.

https://github.com/reactioncommerce/reaction/blob/release-1.8.0/imports/plugins/core/accounts/client/components/updatePasswordOverlay.js#L33

As seen in the gif here: http://g.recordit.co/F9BwrqGl2g.gif, if you manually set the state for "showSpinner" to false, you are able to enter your password and complete creating your account.

Steps to reproduce

  1. Use branch release-1.8.0
  2. invite a user to become a shop manager from the accounts screen
  3. Follow that link in a new session (incognito or similar)
  4. Observer spinner
  5. In react devtools find the Reaction(UpdatePasswordOverlay) component and setshowSpinner` to false
  6. Input your password and see that your account is created
brent-hoover commented 6 years ago

Closed via #3806