Anonymous customer no longer added to "guest" group in release-1.9.0

reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.

https://mailchimp.com/developer/open-commerce/

GNU General Public License v3.0

12.34k stars 2.17k forks source link

Anonymous customer no longer added to "guest" group in release-1.9.0 #3946

Closed brent-hoover closed 6 years ago

brent-hoover commented 6 years ago

Prerequisites

[X] Are you running the latest version?
[X] Are you able to consistently reproduce the issue?
[X] Did you search the issue queue for existing issue? Search issues

Issue Description

In master, customers checking out were added to the guest group but in release-1.9.0 they are not.

Steps to Reproduce

Checkout master, check out anonymously
Pull up Accounts and view that the Account created has the guest group added here
Checkout release-1.9.0, check out anonymously
Observe that this newly created Account does not have that group

brent-hoover commented 6 years ago

I am not 100% sure of the impact because I don't know how this affects things downstream so I am cautiously making this impact-major

prinzdezibel commented 6 years ago

Can't confirm that this works in master. I'm on this commit: * master 766c97ebf [origin/master] Merge pull request #3855 from reactioncommerce/release-1.8.2

(used stripe payment method, which required a email address, so not totally sure if that makes a difference.)

prinzdezibel commented 6 years ago

Can't see that this works in master either. Going to downgrade it to impact-minor again and switching over to something more important.

brent-hoover commented 6 years ago

If you can't reproduce, please close. We can always reopen.