reactioncommerce / reaction

Mailchimp Open Commerce is an API-first, headless commerce platform built using Node.js, React, GraphQL. Deployed via Docker and Kubernetes.
https://mailchimp.com/developer/open-commerce/
GNU General Public License v3.0
12.29k stars 2.17k forks source link

Task: Cleanup unused `enabled` property in plugins #4064

Closed prinzdezibel closed 4 years ago

prinzdezibel commented 6 years ago

Prerequisites

Issue Description

Each plugin has a property called enabled. This boolean originally was intended to control, if the plugin's setting form was displayed in the admin dashboard. It seems that this is no longer the case, i.e. the plugin is visible regardless of the state of this boolean property. This was tested with tax plugins (taxes-taxcloud, taxes-avalara) as well as with payment plugins (e.g. reaction-stripe).

Also this property would presumably be obsolete when we start to move individual plugins to NPM, because then the installation would be controlled through NPM itself.

This issue proposes to eliminate the property altogether, because it seems not to be used anyway right now.

robo_3t_-_1_1

Versions

Node: 8.2.1 NPM: 5.3.0 Meteor Node: 8.9.4 Meteor NPM: 5.6.0 Reaction CLI: 0.26.4 Reaction: 1.10.0 Reaction branch: master Docker: 17.03.1-ce

aldeed commented 4 years ago

Done in 3.0