Closed ScyDev closed 7 years ago
@ScyDev Hey Lukas, if you want to have something merged into core, you would want to open a PR not an issue. But without looking at this more, is there a reason these couldn't be standalone add-on packages? I think some of this stuff has broad appeal (ratings, etc), but some of it seems like it might be more specific to certain implementations.
Maybe we can discuss what's the best way to move this info core.
@ScyDev nice work! I'm also thinking about implementing marketplace for one of my project. And I completely agree with @zenweasel, many features could be packaged as independent packages. And used for many other reaction-based systems.
For example:
All this features could be independent from each other and used anybody, who wants this functionality.
@zenweasel Aaron said I should create an issue first. I asked him if he thought these changes could be merged into core and he said yes.
As you can see, most things I already implemented in separate, optional packages.
But for allowing users to be sellers, I had to check product ownership in most of the methods in server/methods/products.js
.
Do you think this could be done in a separate package?
I'm working on putting all the changes I made in core to separate packages. I think it's possible to do it after all. When I started this I didn't know enough to prevent core hacks.
@ScyDev If I'm not mistaken the original idea was attach every product to the shop. And give some users rights to create they own shops in the marketplace. So you can get owner of shop and he will be owner of all products in his shop. But your implementation also could work, we just need to make clarification of marketplace design. @aaronjudd do you have some schemas or thoughts, how this should be implemented ?
Here are few related issues https://github.com/reactioncommerce/reaction/issues?utf8=✓&q=is%3Aissue+is%3Aopen+label%3Amarketplace+
I'm closing this issue for now. Feel free to open it back up if there is movement towards creating a PR out of any of these packages. These packages would need to be migrated from the old Meteor Package style to the new Reaction imports
style of package.
We've got a newer marketplace
branch that is under active development right now.
Check on progress on the marketplace project board
Chat with us regarding Marketplace in our marketplace gitter channel
I've extended RC to allow users to be sellers on this fork: https://github.com/ScyDev/reaction
Core:
Packages:
Dependencies: