unused testing requirements by CI testing

[reactive-firewall]

History:

❓ is this used in CI ?

_Originally posted by @reactive-firewall in https://github.com/reactive-firewall/multicast/pull/51#discussion_r1741403681_

_Originally replied to by @reactive-firewall in https://github.com/reactive-firewall/multicast/pull/51#discussion_r1742803939_

---

Triage:

• [x] So this needs to be triaged and tracked

• [x] . . . and eventually resolved

Read issue's discussion for progress and latest status

[reactive-firewall]

:thinking: Triage:

• This is an enhancement

• the goal is to have separate test requirements used by CI

  • [x] regression testing is as simple as ignoring "test-requirements.txt" (as in what we do now)

  • [x] this can be done with the common heuristic of the file "test-requirements.txt" ~(is there a PEP for this?)~

  • [x] and a minor refactor to CI configs to use "test-requirements.txt" ~should formalize the regression test but making the refactor a NEW test like extras~

  • 💡 also should make the requirements consistant across the multiple config files:

  • [x] setup.*

  • [x] project.toml thingy

  • [x] test-requirements.txt (./tests/requirements.txt)

  • [x] requirements.txt

  • [x] tox.ini

  • [x] CI configs

  • [x] ~Makefile~ (not really needed)

[reactive-firewall]

Note:

Testing requirements (https://github.com/reactive-firewall/multicast/issues/60): The tests/requirements.txt is indeed being installed in the CI workflow, as confirmed by multiple instances in .github/workflows/Tests.yml. I will revise my walkthrough to mark this objective as complete.

Originally posted by @coderabbitai[bot] in https://github.com/reactive-firewall/multicast/issues/75#issuecomment-2342849032

[coderabbitai[bot]]

[!TIP] For best results, initiate chat on the files or code changes.

@reactive-firewall Thank you for bringing attention to this. You are correct, and I apologize for any confusion in my previous statement. After reviewing the .github/workflows/Tests.yml file, I can confirm that the tests/requirements.txt is indeed being installed in the CI workflow. This occurs in multiple jobs, including MATS, COVERAGE-MATS, COVERAGE, INTEGRATION, and EXTRAS.

For example, in the MATS job, we see the following step:

- name: Install dependencies for ${{ matrix.python-version }}
  run: |
    pip install --upgrade "pip>=21.0" "setuptools>=45.0" "wheel>=0.37" "build>=1.0.1";
    pip install -r ./requirements.txt ;
    pip install -r ./tests/requirements.txt || true ;

It's worth noting that the || true at the end of the pip install -r ./tests/requirements.txt command means that the workflow will continue even if this specific installation step fails. This could be a deliberate choice to ensure the workflow doesn't break if there are any issues with the tests/requirements.txt file.

Thank you for your attention to detail. It's important to have accurate information about the CI process, and I appreciate the opportunity to correct and clarify this point.

(_/) (^.^) /> <\ Thoughtful bunny is glad to provide accurate information!

Analysis chain

Scripts executed

The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # View the contents of .github/workflows/Tests.yml cat .github/workflows/Tests.yml ``` Length of output: 21651

---

Learnings added

``` Learnt from: reactive-firewall URL: https://github.com/reactive-firewall/multicast/issues/60 Timestamp: 2024-09-12T01:37:56.023Z Learning: The tests/requirements.txt file is installed in multiple jobs in the CI workflow (.github/workflows/Tests.yml), including MATS, COVERAGE-MATS, COVERAGE, INTEGRATION, and EXTRAS. The installation command includes `|| true`, allowing the workflow to continue even if the installation of tests/requirements.txt fails. ``` > Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure [review instructions](https://docs.coderabbit.ai/guides/review-instructions). You can manage existing learnings in the [app](https://app.coderabbit.ai/learnings).