Use database to keep track of session cleaning - Githubissues

reactive-python / reactpy-django

It's React, but in Python. Now with Django integration.

https://reactive-python.github.io/reactpy-django/

MIT License

322 stars 18 forks source link

Use database to keep track of session cleaning #167

Closed Archmonger closed 1 year ago

Archmonger commented 1 year ago

Description

Use database to keep track of when ReactPy last performs a clean.
- Previously done via a cache entry for performance. But realistically we should assume the user is either utilizing a performant DB, or doesn't care about performance to begin with.
Store web module file contents in cache, instead of the HTTP Response
Add a timeout to the web module cached files to allow old entries to be deleted.

Checklist:

Please update this checklist as you complete each item:

[x] Tests have been included for all bug fixes or added functionality.
[x] The changelog has been updated with any significant changes, if necessary.
[x] GitHub Issues which may be closed by this PR have been linked.

Archmonger commented 1 year ago

Merging so I can create a v3.3.0 release. Will handle review comments in a follow up PR if needed.