reactive-python / reactpy-django

It's React, but in Python. Now with Django integration.
https://reactive-python.github.io/reactpy-django/
MIT License
322 stars 18 forks source link

Use `NodeJS-bin` instead of the user's `node` install #208

Closed Archmonger closed 7 months ago

Archmonger commented 7 months ago

Description

Our test suite currently relies on the user manually installing NodeJS in order for npm commands to be run.

This is an error prone process with way to control what npm version the end-user has. This method also can also fail due to missing PATH variables.

This PR uses premade binaries for npm instead of the user's local npm installation.

Checklist:

Please update this checklist as you complete each item:

By submitting this pull request you agree that all contributions comply with this project's open source license(s).

Archmonger commented 7 months ago

FYI @rmorshea

NodeJS-Bin seems pretty nice to me. It's a bit unfortunate the author stopped posting version updates beyond 18.x, but for our purposes 18.x works.