need to copy scheme from base url - Githubissues

reactive-python / reactpy

It's React, but in Python

https://reactpy.dev

MIT License

7.74k stars 318 forks source link

need to copy scheme from base url #1118

Closed rmorshea closed 11 months ago

rmorshea commented 11 months ago

_{By submitting this pull request you agree that all contributions to this project are made under the MIT license.}

Issues

Tests are broken (likely due to an update to requests). URL resolution in module_from_template is missing a scheme and hostname.

Solution

Copy the base URL scheme and hostname when resolving relative URLs.

Checklist

[x] Tests have been included for all bug fixes or added functionality.
[x] The changelog.rst has been updated with any significant changes.