search

reactive-python / reactpy

It's React, but in Python
https://reactpy.dev
MIT License
7.85k stars 315 forks source link

Sanic warning when running via docs instructions #1154

Closed Archmonger closed 7 months ago

Archmonger commented 11 months ago

Discussed in https://github.com/reactive-python/reactpy/discussions/1150

Originally posted by **JamesHutchison** October 6, 2023 The docs currently recommend running via Sanic directly. https://reactpy.dev/docs/guides/getting-started/running-reactpy.html#running-with-sanic However, if you do, you get this warning: `No scope. Sanic may not be running with an ASGI server` It seems like if users should be using the built-in Sanic server then this warning should be remove, as it is emitted by ReactPy here: https://github.com/reactive-python/reactpy/blob/main/src/py/reactpy/reactpy/backend/sanic.py#L167 If users should be using ASGI to serve Sanic, then instructions on how to do that should be provided.
Archmonger commented 7 months ago

Closing in favor of #1110