reactive-python / reactpy

It's React, but in Python
https://reactpy.dev
MIT License
7.74k stars 318 forks source link

Add <marquee> element #1164

Closed Minejerik closed 7 months ago

Minejerik commented 7 months ago

This commit simply adds the option to use the marquee element in reactpy. While yes, the marquee element has been deprecated, I think that it would be best to allow web developers the freedom to use this element even when it is deprecated. Also the marquee element is still usable in all major browsers.

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

The issue was that I was unable to use the marquee element in a project I was working on.

Solution

I simply added the marquee element in html.py

Checklist

rmorshea commented 7 months ago

Looks like <marquee> is deprecated according to Mozilla. Given that, it doesn't seem like we should add this to ReactPy. If needed, you can always create this using reactpy.vdom("marquee", ...). Thanks for the contribution though!