search

reactive-python / reactpy

It's React, but in Python
https://reactpy.dev
MIT License
7.89k stars 317 forks source link

fix sdist #1191

Closed rmorshea closed 3 weeks ago

rmorshea commented 9 months ago

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

Closes: https://github.com/reactive-python/reactpy/discussions/1180 Closes: https://github.com/reactive-python/reactpy/pull/1183

Solution

Create a link to the JS directory inside src/py/reactpy and include the JS dir as an sdist-only artifact

Checklist

rmorshea commented 9 months ago

~@Archmonger I'm having some trouble with this on Windows, do you think you can try this branch out and see what's happening. In the meantime I'm gonna purchase a Windows license and install it on an old laptop so I can test this stuff myself going forward.~

Never mind. Got past the windows issue.

shawncrawley commented 3 weeks ago

We're at the final stretch of releasing a new version of our software (Tethys Platform) that introduces reactpy (see this PR). Because our project is deeply rooted in the conda world, the last item that remains is getting reactpy, reactpy-router and reactpy-django added to the conda-forge channel (essentially addressing discussion #850).

I already submitted a PR to the conda-forge/staged-recipes repo, but the automated build checks are failing due to this same sdist issue. So this is my current roadblock. I'm highly motivated to help move things along, but unfortunately I'm fairly novice in many of the underlying technologies/infrastructure used by this project (e.g. Hatch, Invoke, NodeJS, NPM). I'm slowly trying to get up to speed to be more helpful, and will continue to see if there's anything I can tackle myself here. Thanks for everything you've stepped in to do for me in the meantime.

Archmonger commented 3 weeks ago

I will take a stab at finalizing this PR soon.

There's honestly a lot I want to do to "streamline" the CI in core, but I'll need to do that in a future PR.

Archmonger commented 3 weeks ago

I'm going to count this as "good enough".

Functionally works, but is fairly janky. As mentioned in my previous post, I'll need to overhaul all of core's CI in a future PR to get rid of the jank.