search

reactive-streams / reactive-streams-dotnet

Reactive Streams for .NET
MIT No Attribution
199 stars 28 forks source link

Please make sure the NuGet release supports the portable profile #12

Closed akarnokd closed 8 years ago

akarnokd commented 8 years ago

If not already ensured, please release the NuGet library so it can be consumed from a portable profile. (The assembly has to be compiled this way, unlike Java).

cconstantin commented 8 years ago

@akarnokd I've targeted a portable profile in building the nuget package: https://github.com/alignedsolutions/reactive-streams-dotnet/commit/05ca8b1f49d0585e3c365a8940741ac7f109f5b2

Can you try to pack that locally and see if you can consume it from a portable profile?

akarnokd commented 8 years ago

Not really, I know only how to import from NuGet via the VS GUI.

cconstantin commented 8 years ago

@akarnokd you can easily create a local source and placed the generated package there: https://docs.nuget.org/create/hosting-your-own-nuget-feeds

akarnokd commented 8 years ago

Sure, on it. A quick feedback: I had to manually enable generating the XML docs in the build properties; not sure if this property is saved to a project or not.

akarnokd commented 8 years ago

Thanks, the local NuGet import works!

cconstantin commented 8 years ago

Awesome, thanks for confirming @akarnokd . Also enabled the xml docs, thanks for pointing it out.

One more thing? Can you reference the package from a regular net45 profile?

marcpiechura commented 8 years ago

PCL support is now included in #9 so this can be closed.

viktorklang commented 8 years ago

closing