search

reactive-streams / reactive-streams-dotnet

Reactive Streams for .NET
MIT No Attribution
199 stars 28 forks source link

Fix missing Cancel() in tests that don't consume the entire source #32

Closed akarnokd closed 7 years ago

akarnokd commented 7 years ago

Some of the TCK tests didn't cancel their ISubscriptions when they stopped consuming the source which could lead to resource leaks.

This is also an issue in the JVM version of the tck: https://github.com/reactive-streams/reactive-streams-jvm/pull/346

Aaronontheweb commented 7 years ago

cc @Silv3rcircl3

marcpiechura commented 7 years ago

@akarnokd could you please add yourself to the copyright file? Thx. Will merge once it's merged on the jvm too.

akarnokd commented 7 years ago

Done in #33.

viktorklang commented 7 years ago

Ping @ktoso, thoughts? :)

ktoso commented 7 years ago

Will have a look - was in my todo list, fell asleep in the evening though, kind of tired ;)