search

reactive-tech / kubegres

Kubegres is a Kubernetes operator allowing to deploy one or many clusters of PostgreSql instances and manage databases replication, failover and backup.
https://www.kubegres.io
Apache License 2.0
1.32k stars 74 forks source link

Feature request: set custom container image for backup cronjob #82

Open williamkray opened 2 years ago

williamkray commented 2 years ago

This is a great project, thank you so much for putting it together!

I have not implemented kubegres yet but I am reviewing the docs and code in preparation, and I do not see a way to customize the container used for the backup cronJob. The linked example from the documentation shows how to override the backup bash script to use S3 as the destination, however this method requires additional tooling (aws cli) to be added to the postgres image used for all instances in the cluster.

My request is toallow using a unique image for the backup job, so that any additional tooling or packages can be isolated to that process, while still allowing use of the official postgres images for the actual database instances. As the backup process can be customized, I believe so too should the tooling for that backup without requiring customized database images.

Thank you for considering my feedback!

anthonator commented 2 years ago

@williamkray I dug into the code and it looks like backups are run with the same image as the Kubegres resource. You can provide a custom image with everything you need for your backup use-case that way.

williamkray commented 2 years ago

thanks @anthonator. this feature request is to allow using a unique image for the backup job, so that any additional tooling or packages can be isolated to that process, while still allowing use of the official postgres images for the actual database instances.

anthonator commented 2 years ago

Got it. Missed that part in the original post.

alex-arica commented 2 years ago

@anthonator thank you for your help.

@williamkray Thank you for your feedback and your message.

I agree that it will a useful feature. I added it in the backlog.

If a developer is willing to implement this change, I am available to review their PR.

We decided to let the community to be more involved in the project and therefore until end of summer 2022, I will only make a code change when it is required.

With this approach, we are hoping there would be additional developers involved in this project and more PRs submitted.