reactivemarbles / ObservableEvents

MIT License
125 stars 10 forks source link

Update parser packages to support c# 10? #132

Closed AsafMahlev closed 2 years ago

AsafMahlev commented 2 years ago

I'm using .net 6/c# 10 on an avalonia project, and when using the generator it doesn't seem to generate anything.

Downloading it locally and testing it on a random source file, it seems to fail on parsing syntax like file-scoped namespaces, so I assume it might be related to this.

The Microsoft.CodeAnalysis packages are at 3.11.0, where the newest ones are 4.2.0

Changing the package let me run the command line test without errors, but I can't figure out how to run it in my project as a local dll

glennawatson commented 2 years ago

More detail please?

AsafMahlev commented 2 years ago

Sorry, it accidentally was blank

glennawatson commented 2 years ago

133 is the work I'm doing allowing dual Roslyn versions which sounds like it'll address your issues. Not quite ready yet.

The code analysis version is locked to a visual studio version so using the dual targeting feature allows updated use of newer features.

AsafMahlev commented 2 years ago

It seem that even after updating it doesn't generate any events. Is there a way to run it with more information?

glennawatson commented 2 years ago

You can test a local project with https://github.com/reactivemarbles/ObservableEvents/blob/260288b060662936f2e082f192e9529624bab8e7/src/ReactiveMarbles.ObservableEvents.Example/ReactiveMarbles.ObservableEvents.Example.csproj#L14

glennawatson commented 2 years ago

Btw if you can provide a sample of failing code I can include it in the unit tests when I get #133 in

AsafMahlev commented 2 years ago

Sorry - it seems that my issue was unrelated (trying to use it with another source generator), and the failure I saw in the sample Program.cs does not happen in practice in my project. I apologize for the inconvenience.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.