Consider exposing Vert.x HttpClientOptions

reactiverse / aws-sdk

Using vertx-client for AWS SDK v2

Apache License 2.0

49 stars 14 forks source link

Consider exposing Vert.x HttpClientOptions #46

Closed oxsdd closed 4 years ago

oxsdd commented 4 years ago

My particular situation required supporting a proxy server, so I forked and hard coded the required additional ProxyOptions in the VertxNioAsyncHttpClient, where the Vert.x HttpClient is created.

It would perhaps be beneficial to support passing Vert.x HttpClientOptions as an optional parameter in the VertSdkClient.withVertx call?

aesteve commented 4 years ago

Good point thank you.

aesteve commented 4 years ago

You should be able to do so in 0.6.0, thanks again for the report.

oxsdd commented 4 years ago

Great, thank you!