search

reactiverse / aws-sdk

Using vertx-client for AWS SDK v2
Apache License 2.0
49 stars 14 forks source link

Response should be paused #63

Open zenios opened 1 year ago

zenios commented 1 year ago

https://github.com/reactiverse/aws-sdk/blob/883755f9068ea111ba54736ba4b473d6d681eb3d/src/main/java/io/reactiverse/awssdk/VertxNioAsyncHttpClient.java#L86

Hi

Response should be paused until the subscriber (ReadStreamPublisher) requests data via (stream.fetch(n) which automatically resumes) else you are having the chance of missing data. This is visible when you are fetching big files from s3

aesteve commented 1 year ago

Thanks a lot for reporting this!

Is there any chance you can provide a reproducer with Localstack (in the same fashion as the existing integration tests)?

I'll try to give it a look at some point when I get some time, but the more input the faster it'll be for sure.