reactiverse / es4x

🚀 fast JavaScript 4 Eclipse Vert.x
https://reactiverse.io/es4x/
Apache License 2.0
882 stars 75 forks source link

Docs/gr #411

Closed AntoniosBarotsis closed 3 years ago

AntoniosBarotsis commented 3 years ago

Translated half of the documentation to Greek. As mentioned in this reply of this issue, the second half will be finished by @Petros0

codecov[bot] commented 3 years ago

Codecov Report

Merging #411 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #411   +/-   ##
==========================================
  Coverage      58.39%   58.39%           
  Complexity       201      201           
==========================================
  Files             17       17           
  Lines           1019     1019           
  Branches         197      197           
==========================================
  Hits             595      595           
  Misses           301      301           
  Partials         123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a85216...3348c04. Read the comment docs.

AntoniosBarotsis commented 3 years ago

I'm not sure if the second half will be added in this particular pr or if it will be a separate one but in any case I would ask you to consider merging this before Monday so it counts towards the 4 prs you have to make for hacktoberfest :)

pmlopes commented 3 years ago

@AntoniosBarotsis no worries, I'll wait a couple of days, but will merge within the hacktoberfest run.

AntoniosBarotsis commented 3 years ago

Thanks! Just a heads up: A pr is considered invalid if not merged within 7 days of it's creation!

AntoniosBarotsis commented 3 years ago

The second half of the translation has been posted here, this can be merged!

pmlopes commented 3 years ago

Thanks @AntoniosBarotsis

The only missing step is the labels on the config:

https://github.com/reactiverse/es4x/blob/develop/docs/.vuepress/config.js#L397-L485

If you or @Petros0 can have a look, then a new PR is welcome!

Thanks!