search

reactiverse / es4x

🚀 fast JavaScript 4 Eclipse Vert.x
https://reactiverse.io/es4x/
Apache License 2.0
882 stars 75 forks source link

does it conflict with typescript? #459

Closed fantasy0v0 closed 3 years ago

fantasy0v0 commented 3 years ago

Screenshot from 2020-11-23 10-09-36

Version: 3.9.4 conflict when i install other typescript package

fantasy0v0 commented 3 years ago

maybe can add "@types/node": "*" in devDependencies and delete these in es4x.d.ts.

pmlopes commented 3 years ago

Hi, I can't really delete those, because if you don't use any dependency that would pull @types/node then it would also fail. I think I need to annotate those overrides as allowed to be ignored on error.

pmlopes commented 3 years ago

I'll check if adding // @ts-ignore on those types will make it safe or not.

pmlopes commented 3 years ago

I've added those to CR2