search

reactiverse / es4x

🚀 fast JavaScript 4 Eclipse Vert.x
https://reactiverse.io/es4x/
Apache License 2.0
882 stars 75 forks source link

i found some errors in 0.14.0-CR1 #464

Closed fantasy0v0 closed 3 years ago

fantasy0v0 commented 3 years ago

my version: VM: OpenJDK 64-Bit Server VM - 14.0.2 VM Vendor: null Vert.x: 4.0.0.CR1 ES4X: 0.14.0-CR1 graaljs: 20.2.0

  1. package.json has extra characters

image

This problem is caused by com.github.cliftonlabs.json_simple.Jsoner#prettyPrint https://github.com/reactiverse/es4x/blob/d51190a6d3747397970ab814c36d38dc9e64b5d1/pm/src/main/java/io/reactiverse/es4x/commands/JSON.java#L39

System.out.println(Jsoner.prettyPrint("{\"@es4x/create\"}"));

will print 

{
    "@es4x\/create"
}
  1. wrong version number

version of @vertx/core is 4.0.0-CR1 not 4.0.0.CR1

  1. Module '"./enums"' has no exported member 'TracingPolicy'.

node_modules/@vertx/core/options.d.ts:1767:10 - error TS2305:

pmlopes commented 3 years ago

Thanks for the report @fantasy0v0 I've just pushed to develop a fix to avoid relying on simple-json. so the generated json is correct now.

I've to figure out why the TracingPolicy is missing.

pmlopes commented 3 years ago

Following up here: https://github.com/eclipse-vertx/vert.x/pull/3683

pmlopes commented 3 years ago

The json bug is also fixed!

pmlopes commented 3 years ago

@fantasy0v0 I've prepared a new release 0.14.0 currently if you're testing using maven you can verify the artifacts if you use the following statging maven repo:

https://oss.sonatype.org/content/repositories/ioreactiverse-1147/

pmlopes commented 3 years ago

0.14.0 is being pushed to mirrors, all bits on maven and npm.