reactiveui / Pharmacist

Builds observables from events.
MIT License
239 stars 15 forks source link

[BUG] Can't handle generic base classes #80

Closed modplug closed 3 years ago

modplug commented 4 years ago

Describe the bug

Pharmasist does not pick up events contained in a base class with generics.

public class TabbedPage : MultiPage, IBarElement, IElementConfiguration

Steps To Reproduce

Add pharmacist to your Xamarin Forms project. Try to access observables from events generated from a page with generics. public class TabbedPage : MultiPage, IBarElement, IElementConfiguration

Events like CurrentPageChanged is not generated.

Environment Xamarin Forms 4.3

open-collective-bot[bot] commented 4 years ago

Hey @modplug :wave:,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.

https://opencollective.com/reactiveui

PS.: We offer priority support for all financial contributors. Don't forget to add priority label once you start contributing :smile:

ReactiveUI - Open Collective
An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!
glennawatson commented 3 years ago

See https://www.nuget.org/packages/ReactiveMarbles.ObservableEvents.SourceGenerator/ and https://github.com/reactivemarbles/ObservableEventsSourceGenerator

This will handle generic base classes I believe.

ReactiveMarbles.ObservableEvents.SourceGenerator 1.0.2
Allows to get an observables for property changed events.
GitHub
reactivemarbles/ObservableEventsSourceGenerator
Contribute to reactivemarbles/ObservableEventsSourceGenerator development by creating an account on GitHub.
github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.