reactiveui / ReactiveUI.SourceGenerators

Use source generators to generate objects.
MIT License
31 stars 3 forks source link

Fix Forward Attributes to Generated Code #117

Closed ChrisPulman closed 2 weeks ago

ChrisPulman commented 2 weeks ago

Remove Attribute collection and forwarding

What kind of change does this PR introduce?

Fixes #116

What is the current behavior?

IViewFor forwards Attributes defined in source incorrectly

What is the new behavior?

IViewFor no longer forwards Attributes defined

What might this PR break?

Non due to non-compiling code if using in this way.

Please check if the PR fulfills these requirements

Other information:

glennawatson commented 2 weeks ago

Is it worth adding a couple unit tests for this one? At least some verification ones.

ChrisPulman commented 2 weeks ago

Is it worth adding a couple unit tests for this one? At least some verification ones.

We need to amend the tests to work with wpf / winforms first but definitely in the pipeline

github-actions[bot] commented 3 days ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.