search

reactiveui / ReactiveUI.SourceGenerators

Use source generators to generate objects.
MIT License
31 stars 3 forks source link

Please support "virtual" #122

Closed neominky closed 2 weeks ago

neominky commented 2 weeks ago

Is your feature request related to a problem? Please describe.

I want to use change-tracking functionality like 'ChangeTracking' or 'trackerdog' together. To use the proxy, properties need to be declared as virtual.

Describe the solution you'd like

[Reactive(SetModifier = AccessModifier.Public, Overridable = true)] private string _nodeName;

PremekTill commented 2 weeks ago

A similar issue occurs when implementing an abstract or virtual property defined in a base class, where the generated code lacks the override keyword. As such, instead of a simple boolean switch, I would maybe consider something like an InheritanceModifier enum with values of None, Virtual, Override and New to cover all of the possible modifiers (aside from Abstract, which obviously doesn't make sense when generating an implementation).

github-actions[bot] commented 5 days ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.