search

reactiveui / ReactiveUI.Validation

Validation helpers for ReactiveUI-based apps.
https://reactiveui.net/docs/handbook/user-input-validation
MIT License
235 stars 24 forks source link

Fix for Memory Leak #660

Closed ChrisPulman closed 4 months ago

ChrisPulman commented 4 months ago

What kind of change does this PR introduce?

Fix for #659

What is the current behavior?

A memory leak exists in the ValidationContext

What is the new behavior?

ValidationContext has been updated to remove the leak ReadOnlyCollectionPooled has been removed ReadOnlyDisposableCollection has replaced ReadOnlyCollectionPooled

What might this PR break?

Disposing will clean the Resorces created

Please check if the PR fulfills these requirements

Other information:

ChrisPulman commented 4 months ago

Looks like the ReadOnlyCollectionPooled is also not releasing, it runs fine on my PC, but not on the build server, I will take a look later.

github-actions[bot] commented 3 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.