Open xecrets opened 6 months ago
Ping? Anyone here?
Ok, so here's what seems to have happened. In commit https://github.com/reactiveui/ReactiveUI.Validation/commit/5d0c8121e62c26745332695439a54651c1fd09f1 for issue #652 "Housekeeping Retire Xamarin" ReactiveValidationObject
has a breaking change in that it now implements IDisposable
. A ViewModel for example inheriting from ReactiveValidationObject
after this change needs to ensure that it's actually disposed. Otherwise the above issue occurs. @ChrisPulman - perhaps this should be noted somewhere to clarify?
Describe the bug š
Upgrading from 3.1.7 to 4.0.9, in an app running AvaloniaUI 11.0.10 undesirable new behavior is shown. An ObjectDisposedException is thrown, although apparently caught/ignored/hidden higher up in the call stack, this is still undesirable and constitutes a code smell. Exceptions that can be avoided should be avoided.
Step to reproduce
I don't have a minimum reproduceable sample unfortunately, and the app in question is not open source. Hopefully somebody who knows what has changed and examining the call stack below will recognize the root cause. The change in behavior occurs with no other change than upgrading from 3.1.7 to 4.0.9, and has been re-confirmed by downgrading (no issue) and upgrading again (new behavior is back).
Reproduction repository
No response
Expected behavior
In normal usage, exceptions should not be thrown, and specifically not ObjectDisposedException. Notable also is that it's a changed behavior from 3.1.7 to 4.0.9 .
Full call stack follows:
Screenshots š¼ļø
No response
IDE
Visual Studio 2022
Operating system
Windows
Version
No response
Device
PC
ReactiveUI Version
4.0.9
Additional information ā¹ļø
No response