search

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.
https://www.reactiveui.net
MIT License
8.07k stars 1.12k forks source link

Improve XF ActivationForViewFetcher #1333

Open kentcb opened 7 years ago

kentcb commented 7 years ago

Do you want to request a feature or report a bug?

Feature.

What is the current behavior?

Doesn't handle dialogs. That is, if a dialog is shown, the page under it is deactivated. This can cause really annoying and difficult to understand problems.

Also, it still pretends to support View instances. It should throw instead of the false pretenses.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

I guess you could argue it's a bug, but I'd say it's working by design, but the design did not have sufficient foresight.

What is the expected behavior?

I've been running with my own custom ActivationForViewFetcher for a while now. It's the same as the built-in one, but removes support for View activation and keeps the page at the top of the navigation stack activated (even if it's hidden by a dialog).

What is the motivation / use case for changing the behavior?

Stop trolling me and other people.

Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.

7.2

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this because it helps reduce the workload of our extremely busy maintainers. If you want this issue progressed faster please start talks with a maintainer with how you can help out. There are so many ways to contribute to open-source and the most valued are often not code related. We are always looking for more help and look after those who stick around. Say howdy to one of the maintainers or browse https://reactiveui.net/contribute/ for ideas on where to start your journey.