search

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.
https://www.reactiveui.net
MIT License
8.1k stars 1.12k forks source link

Blazor: Make CompositeDisposable accessible from derived components #2783

Closed TenBuck closed 3 years ago

TenBuck commented 3 years ago

Is your feature request related to a problem? Please describe.

I want to easily hook to base component composite disposable in derived ReactiveComponentBase

Describe the solution you'd like

Make CompositeDisposable protected (or public) https://github.com/reactiveui/ReactiveUI/blob/5c2665d27049add007e67bbb665b80e978925bd3/src/ReactiveUI.Blazor/ReactiveComponentBase.cs#L29

Describe alternatives you've considered

overriding virtual Dispose and using private CompositeDisposable. This works well but is not as clean and requires boilerplate

Describe suggestions on how to achieve the feature

Make CompositeDisposable protected https://github.com/reactiveui/ReactiveUI/blob/5c2665d27049add007e67bbb665b80e978925bd3/src/ReactiveUI.Blazor/ReactiveComponentBase.cs#L29

Additional context

glennawatson commented 3 years ago

We won't be exposing this due to it just being logic for internal activation logic.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.