search

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.
https://www.reactiveui.net
MIT License
8.12k stars 1.12k forks source link

Change POCO type binding warning level to debug #3415

Open database64128 opened 2 years ago

database64128 commented 2 years ago

Is your feature request related to a problem? Please describe.

Currently the POCO type binding warning messages are at the warn level. My GUI application has a log widget in the main interface for displaying logs. These warnings tend to spam the logs and are quite annoying:

2022-11-16T11:23:46.4433272+01:00 [W] The class YoutubeDl.Wpf.MainWindow property rootDialogHost is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:46.4645744+01:00 [W] The class YoutubeDl.Wpf.MainWindow property mainTabControl is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1145984+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property nameTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1169115+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property formatTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1170914+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property containerTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1268472+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property backendYoutubeDlCheckBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1310636+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property backendYtDlpCheckBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1417348+01:00 [W] The class YoutubeDl.Wpf.Views.PresetDialogView property argumentsItemsControl is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1589010+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property linkTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1677745+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property downloadButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1763718+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property presetComboBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1894582+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property subtitlesDefaultCheckBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1898361+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property subtitlesAllLanguagesCheckBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1900477+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property subtitlesAutoGeneratedCheckBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1908205+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property metadataToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1939119+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property thumbnailToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1942785+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property playlistToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1945009+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property filenameTemplateToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.1969702+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property filenameTemplateTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.2010593+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property pathToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.2013892+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property pathComboBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.2083072+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property argumentsItemsControl is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.2101350+01:00 [W] The class YoutubeDl.Wpf.Views.HomeView property resultTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.4657208+01:00 [W] The class YoutubeDl.Wpf.Views.AddArgumentView property argumentTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.8403390+01:00 [W] The class YoutubeDl.Wpf.Models.BackendArgument property Argument is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:47.8408435+01:00 [W] The class YoutubeDl.Wpf.Views.ArgumentChipView property argumentChip is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3638320+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property systemColorModeRadioButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3652829+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property lightColorModeRadioButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3655966+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property darkColorModeRadioButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3707753+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property ytdlBackendTypeRadioButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3732819+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property ytdlpBackendTypeRadioButton is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3749161+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property dlPathTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3756483+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property argumentsItemsControl is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.3823531+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property autoUpdateDlToggle is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.4219697+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property lastUpdateCheckTextBlock is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.4230122+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property ffmpegPathTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.4233105+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property proxyTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.4286278+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property maxLogEntriesTextBox is a POCO type and won't send change notifications, WhenAny will only return a single value!
2022-11-16T11:23:54.4297616+01:00 [W] The class YoutubeDl.Wpf.Views.SettingsView property versionTextBlock is a POCO type and won't send change notifications, WhenAny will only return a single value!

Describe the solution you'd like

Change the level of these messages to debug, so they won't show up at production. They are only useful during development anyway.

Describe alternatives you've considered

Can't think of any.

Describe suggestions on how to achieve the feature

As stated above.

Additional context

Several user reports in my project: database64128/youtube-dl-wpf#128, database64128/youtube-dl-wpf#160

glennawatson commented 1 year ago

The warning level is deliberate.

A better fix is to detect if the source is a WPF style control with those properties and handle it appropriately.

That way the warning is useful.