#3792 Leverage framework for dependencies

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.

https://www.reactiveui.net

MIT License

7.99k stars 1.12k forks source link

#3792 Leverage framework for dependencies #3800

Closed thompson-tomo closed 2 months ago

thompson-tomo commented 2 months ago

What kind of change does this PR introduce? update

What is the current behavior? Packages are the same for all TFM's

What is the new behavior? Less dependencies are included for net 6+ due to them being available as part of the framework

What might this PR break? n/a

Other information: closes #3792

thompson-tomo commented 2 months ago

@ChrisPulman change is done.

ChrisPulman commented 2 months ago

Hi James, I had thought I had made this simple by giving you the code to fix the issue, I want to give you credit for this change, but the code must build to accept it, before checking changes in please ensure that the solution builds and all tests pass

thompson-tomo commented 2 months ago

@dpvreony i am not sure what happened but when i copied the code provided it for some reason didn't like the first line even though nothing was visibly different. As such i have pushed a fresh branch which is compiling on my local machine.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.69%. Comparing base (d75f999) to head (8e6d852). Report is 60 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3800 +/- ## =========================================== + Coverage 59.03% 69.69% +10.66% =========================================== Files 160 136 -24 Lines 5847 4726 -1121 Branches 1031 754 -277 =========================================== - Hits 3452 3294 -158 + Misses 2007 1230 -777 + Partials 388 202 -186 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

database64128 commented 2 months ago

This seems to have also fixed dotnet/wpf#8943 for me.

github-actions[bot] commented 1 month ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.