Feature Add Reactive, ObservableAsProperty and ReactiveCommand Source Generators

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.

https://www.reactiveui.net

MIT License

8.06k stars 1.12k forks source link

Feature Add Reactive, ObservableAsProperty and ReactiveCommand Source Generators #3856

Closed ChrisPulman closed 2 months ago

ChrisPulman commented 2 months ago

What kind of change does this PR introduce?

Feature

What is the current behavior?

Fody is currently available for [Reactive] and [ObservableAsProperty]

What is the new behavior?

[Reactive] [ObservableAsProperty] Field Attributes and a [ReactiveCommand] Method Attribute with Source Generators now added.

What might this PR break?

There are differences between the old Fody injector and the new Source Generator both in the Attribute location and the operation.

Documentation must be updated to coincide with a release.

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

glennawatson commented 2 months ago

There is a separate repo for the source generators, probably best to separate since source-generators don't have a dependency on the rxui version.

glennawatson commented 2 months ago

https://github.com/reactiveui/ReactiveUI.ObjectGenerators

GitHub
GitHub - reactiveui/ReactiveUI.ObjectGenerators: Use source generators to generate objects.
Use source generators to generate objects. . Contribute to reactiveui/ReactiveUI.ObjectGenerators development by creating an account on GitHub.

ChrisPulman commented 2 months ago

https://github.com/reactiveui/ReactiveUI.ObjectGenerators

GitHubGitHub - reactiveui/ReactiveUI.ObjectGenerators: Use source generators to generate objects.Use source generators to generate objects. . Contribute to reactiveui/ReactiveUI.ObjectGenerators development by creating an account on GitHub.

Thank you, I will move it to this repository. It has no direct dependency to ReactiveUI.

GitHub
GitHub - reactiveui/ReactiveUI.ObjectGenerators: Use source generators to generate objects.
Use source generators to generate objects. . Contribute to reactiveui/ReactiveUI.ObjectGenerators development by creating an account on GitHub.

ChrisPulman commented 2 months ago

Moved to https://github.com/reactiveui/ReactiveUI.SourceGenerators/pull/3

github-actions[bot] commented 2 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.