search

reactiveui / ReactiveUI

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.
https://www.reactiveui.net
MIT License
8.12k stars 1.12k forks source link

Fix to enable use of DynamicData 9.0 #3875

Closed ChrisPulman closed 3 months ago

ChrisPulman commented 3 months ago

What kind of change does this PR introduce?

fix

What is the current behavior?

ReactiveUI 20.1.1 includes DynamicData 8 DynamicData 9 has an update to the Observable Change Set which introduces a default value, this results in a mismatch in count between V8 and V9

What is the new behavior?

the default value has been removed from the RoutingState CurrentViewModel

What might this PR break?

Execution should match previous versions

Please check if the PR fulfills these requirements

Other information:

dpvreony commented 3 months ago

do we need to class this as a breaking change? as the dynamicdata behaviour may have knock on effects?

github-actions[bot] commented 3 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.