Closed TimothyMakkison closed 2 weeks ago
Attention: Patch coverage is 94.52055%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 84.89%. Comparing base (
6ebeda5
) to head (288ad31
). Report is 156 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
Refit/RestMethodInfo.cs | 94.11% | 3 Missing and 2 partials :warning: |
Refit/RequestBuilderImplementation.cs | 95.08% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Parse the url target inside
RestMethodInfo
, removing the use of regex on function calls.Re attempt at #1730. Turns out the additional allocations were caused by line 829 creating a closure. Looking at the lowered code C# always created the linq closure, even when round tripping was never used 🤔
In future I could optimise round trip to not use
string.Split
, either manually splitting or usingSpan.Split
Benchmarks (on battery power)
Old benchmarks