feat: add URL fragment tests

reactiveui / refit

The automatic type-safe REST library for .NET Core, Xamarin and .NET. Heavily inspired by Square's Retrofit library, Refit turns your REST API into a live interface.

https://reactiveui.github.io/refit/

MIT License

8.66k stars 744 forks source link

feat: add URL fragment tests #1900

Closed TimothyMakkison closed 3 weeks ago

TimothyMakkison commented 3 weeks ago

Added fragment tests, ensuring that the fragment is always removed. ie /foo#name -> /foo
Updated InvalidParamSubstitutionShouldThrow
Added InvalidFragmentParamSubstitutionShouldThrow

This is to prevent future changes to Uri from breaking things. I'm looking at removing Uri and UriBuilder creation in RequestBuilderImplementation. Out of curiosity why doesn't refit support fragments, is this intentional or an oversight?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.89%. Comparing base (6ebeda5) to head (98cc73d). Report is 157 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1900 +/- ## ========================================== - Coverage 87.73% 84.89% -2.85% ========================================== Files 33 36 +3 Lines 2348 2502 +154 Branches 294 361 +67 ========================================== + Hits 2060 2124 +64 - Misses 208 299 +91 + Partials 80 79 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.