reactiveui / splat

Makes things cross-platform
MIT License
973 stars 142 forks source link

Update Avalonia - ReactiveUI.Avalonia.* to Splat.Avalonia.* #1050

Closed ChrisPulman closed 1 year ago

ChrisPulman commented 1 year ago

What kind of change does this PR introduce?

Update

What is the current behavior?

ReactiveUI.Avalonia does not follow solution names of Splat.

What is the new behavior?

Rename ReactiveUI.Avalonia. to Splat.Avalonia. Remove ReactiveUi.Avalonia Rename Avalonia Tests

What might this PR break?

Packages now have different names, ReactiveUi.Avalonia no longer exists.

Please check if the PR fulfills these requirements

Other information:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 84.90% and project coverage change: -0.51% :warning:

Comparison is base (12f241f) 75.45% compared to head (e9c4ff8) 74.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1050 +/- ## ========================================== - Coverage 75.45% 74.95% -0.51% ========================================== Files 93 95 +2 Lines 4387 4511 +124 ========================================== + Hits 3310 3381 +71 - Misses 1077 1130 +53 ``` | [Files Changed](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui) | Coverage Δ | | |---|---|---| | [....AppCenter/AppCenterFeatureUsageTrackingSession.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkFwcENlbnRlci9BcHBDZW50ZXJGZWF0dXJlVXNhZ2VUcmFja2luZ1Nlc3Npb24uY3M=) | `85.18% <ø> (ø)` | | | [src/Splat.AppCenter/AppCenterViewTracking.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkFwcENlbnRlci9BcHBDZW50ZXJWaWV3VHJhY2tpbmcuY3M=) | `0.00% <ø> (ø)` | | | [.../ApplicationInsightsFeatureUsageTrackingSession.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkFwcGxpY2F0aW9uSW5zaWdodHMvQXBwbGljYXRpb25JbnNpZ2h0c0ZlYXR1cmVVc2FnZVRyYWNraW5nU2Vzc2lvbi5jcw==) | `84.84% <ø> (ø)` | | | [src/Splat.Autofac/AutofacDependencyResolver.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkF1dG9mYWMvQXV0b2ZhY0RlcGVuZGVuY3lSZXNvbHZlci5jcw==) | `81.91% <ø> (ø)` | | | [src/Splat.Common.Test/ViewThatShouldNotLoad.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkNvbW1vbi5UZXN0L1ZpZXdUaGF0U2hvdWxkTm90TG9hZC5jcw==) | `25.00% <ø> (ø)` | | | [src/Splat.Drawing/Bitmaps/BitmapLoaderException.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkRyYXdpbmcvQml0bWFwcy9CaXRtYXBMb2FkZXJFeGNlcHRpb24uY3M=) | `0.00% <ø> (ø)` | | | [src/Splat.Drawing/Colors/SplatColor.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkRyYXdpbmcvQ29sb3JzL1NwbGF0Q29sb3IuY3M=) | `81.66% <ø> (ø)` | | | [src/Splat.Drawing/DefaultPlatformModeDetector.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkRyYXdpbmcvRGVmYXVsdFBsYXRmb3JtTW9kZURldGVjdG9yLmNz) | `0.00% <ø> (ø)` | | | [src/Splat.Drawing/Platforms/ReflectionStubs.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkRyYXdpbmcvUGxhdGZvcm1zL1JlZmxlY3Rpb25TdHVicy5jcw==) | `0.00% <ø> (ø)` | | | [.../Platforms/ServiceLocationDrawingInitialization.cs](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui#diff-c3JjL1NwbGF0LkRyYXdpbmcvUGxhdGZvcm1zL1NlcnZpY2VMb2NhdGlvbkRyYXdpbmdJbml0aWFsaXphdGlvbi5jcw==) | `0.00% <ø> (ø)` | | | ... and [57 more](https://app.codecov.io/gh/reactiveui/splat/pull/1050?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=reactiveui) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpvreony commented 1 year ago

when it's released can someone with nuget access deprecate the old package and mark this as the replacement?

ChrisPulman commented 1 year ago

when it's released can someone with nuget access deprecate the old package and mark this as the replacement?

I understand the original packages have already been unlisted.

ChrisPulman commented 1 year ago

the folder names could do with being tweaked

I will update the folder names in the morning, thank you.

github-actions[bot] commented 1 year ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.