search

reactiveui / splat

Makes things cross-platform
MIT License
969 stars 142 forks source link

Update to Release of Net 8.0 #1064

Closed ChrisPulman closed 10 months ago

ChrisPulman commented 10 months ago

What kind of change does this PR introduce?

Fix code recommendations where relevant

What is the current behavior?

RC version of net 8.0

What is the new behavior?

Release version of net 8.0

What might this PR break?

none expected

Please check if the PR fulfills these requirements

Other information: Latest VS2022 release required for development of Splat as of today

codecov[bot] commented 10 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (42980da) 74.27% compared to head (a06bcd1) 74.14%.

Files Patch % Lines
src/Splat/Maths/PointMathExtensions.cs 0.00% 5 Missing :warning:
src/Splat.Drawing/Bitmaps/BitmapLoader.cs 0.00% 4 Missing :warning:
src/Splat/Logging/LogHost.cs 40.00% 1 Missing and 2 partials :warning:
src/Splat/Logging/DefaultLogManager.cs 50.00% 1 Missing and 1 partial :warning:
...icationInsights/ApplicationInsightsViewTracking.cs 0.00% 1 Missing :warning:
src/Splat.Drawing/Colors/SplatColor.cs 80.00% 1 Missing :warning:
src/Splat/Disposables/BooleanDisposable.cs 0.00% 1 Missing :warning:
src/Splat/Logging/WrappingFullLogger.cs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1064 +/- ## ========================================== - Coverage 74.27% 74.14% -0.14% ========================================== Files 95 95 Lines 5520 5530 +10 Branches 631 632 +1 ========================================== Hits 4100 4100 - Misses 1216 1226 +10 Partials 204 204 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpvreony commented 10 months ago

do we need to bump version.json? minor version?

ChrisPulman commented 10 months ago

There is a small API change so yes we need to bump, however we need to review the TargetFrameworks of Drawing as some of the Android targets seem to have been dropped since yesterday (14th November) in the latest release of Visual Studio which will affect our build process shortly.

Let's review the targets before making a release.

github-actions[bot] commented 9 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.