reactiveui / splat

Makes things cross-platform
MIT License
967 stars 142 forks source link

Fix for API tests, Simplify Targets #1066

Closed ChrisPulman closed 9 months ago

ChrisPulman commented 9 months ago

What kind of change does this PR introduce?

Fix for API tests

What is the current behavior?

API tests do not fail

What is the new behavior?

API tests now fail if change is recognised Simplified targets into mostly a single location for updates

What might this PR break?

Non expected, but part of a breaking change overall

Please check if the PR fulfills these requirements

Other information:

codecov[bot] commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (f63a155) 74.06% compared to head (a6697e2) 69.79%. Report is 1 commits behind head on main.

Files Patch % Lines
src/Splat/ServiceLocation/InternalLocator.cs 10.00% 9 Missing :warning:
src/Splat/TargetFrameworkExtensions.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1066 +/- ## ========================================== - Coverage 74.06% 69.79% -4.28% ========================================== Files 95 95 Lines 5530 4609 -921 Branches 632 633 +1 ========================================== - Hits 4096 3217 -879 + Misses 1230 1186 -44 - Partials 204 206 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 9 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.