search

reactiveui / splat

Makes things cross-platform
MIT License
967 stars 142 forks source link

WIP Feature: Use Microsoft KeyedServiceProvider #1075

Closed OleksandrTsvirkun closed 3 months ago

OleksandrTsvirkun commented 6 months ago

Use KeyedServiceProvider instead of ContractDictionary for Splat.Microsoft.Extensions.DependencyInjection adapter.

What is the current behavior? Splat and ServiceProvider provides different instances of a singleton object https://github.com/reactiveui/splat/issues/1074

What is the new behavior? Splat and ServiceProvider provides the same instance of a singleton object

What might this PR break? Nothing known.

Please check if the PR fulfills these requirements

Other information:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 71.79%. Comparing base (1803c70) to head (17fe3a1). Report is 62 commits behind head on main.

Files Patch % Lines
...DependencyInjection/MicrosoftDependencyResolver.cs 62.85% 5 Missing and 8 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1075 +/- ## ========================================== - Coverage 71.87% 71.79% -0.08% ========================================== Files 96 96 Lines 4483 4429 -54 Branches 569 557 -12 ========================================== - Hits 3222 3180 -42 + Misses 1074 1068 -6 + Partials 187 181 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OleksandrTsvirkun commented 6 months ago

@dpvreony In this case should I provide these test you have mentioned? I need to take some time to think about use cases. Thanks for corresponding

dpvreony commented 6 months ago

@dpvreony In this case should I provide these test you have mentioned? I need to take some time to think about use cases. Thanks for corresponding

leave it with me

dpvreony commented 4 months ago

actually the net6 version supports IKeyedServiceProvider with v8 of the package. headache of framework vs packages

image

i'll tidy up and get this merged

github-actions[bot] commented 3 months ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.