Closed OleksandrTsvirkun closed 3 months ago
Attention: Patch coverage is 62.85714%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 71.79%. Comparing base (
1803c70
) to head (17fe3a1
). Report is 62 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...DependencyInjection/MicrosoftDependencyResolver.cs | 62.85% | 5 Missing and 8 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dpvreony In this case should I provide these test you have mentioned? I need to take some time to think about use cases. Thanks for corresponding
@dpvreony In this case should I provide these test you have mentioned? I need to take some time to think about use cases. Thanks for corresponding
leave it with me
actually the net6 version supports IKeyedServiceProvider with v8 of the package. headache of framework vs packages
i'll tidy up and get this merged
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Use KeyedServiceProvider instead of ContractDictionary for Splat.Microsoft.Extensions.DependencyInjection adapter.
What is the current behavior? Splat and ServiceProvider provides different instances of a singleton object https://github.com/reactiveui/splat/issues/1074
What is the new behavior? Splat and ServiceProvider provides the same instance of a singleton object
What might this PR break? Nothing known.
Please check if the PR fulfills these requirements
Other information: